Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure changelog renderers are resolvable when processing config #23214

Merged
merged 1 commit into from
May 8, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

  • If there is an issue rendering or processing the configured (or default) changelog renderer the underlying error gets swallowed
  • You only find out about the issue as part of the changelog step, which is most likely after projects have already been versioned which could have had side-effects which are cumbersome to undo.

Expected Behavior

  • Any and all issues with resolving changelog renderers is handled upfront during config processing/validation
  • If an error does occur when processing the changelog renderer(s) then that raw error will be surfaced directly to the user

E.g. with the new experience (based on a TS configuration issue in the worksapce which breaks the ts register logic within nx):

image

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner May 7, 2024 12:40
@JamesHenry JamesHenry requested a review from xiongemi May 7, 2024 12:40
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 7, 2024 0:40am

@JamesHenry JamesHenry enabled auto-merge (squash) May 7, 2024 12:40
@fahslaj fahslaj self-requested a review May 8, 2024 13:47
@JamesHenry JamesHenry merged commit 3970a1e into master May 8, 2024
6 checks passed
@JamesHenry JamesHenry deleted the changelog-renderer-catch branch May 8, 2024 17:21
FrozenPandaz pushed a commit that referenced this pull request May 9, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants