Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): align padding for output with failed tasks #23119

Merged
merged 1 commit into from
May 1, 2024

Conversation

Den-dp
Copy link
Contributor

@Den-dp Den-dp commented May 1, 2024

Current Behavior

NX   Ran target lint for 3 projects (3s)

   √  0/3 succeeded [0 read from cache]

   ×  3/3 targets failed, including the following:

      - nx run bar:lint
       - nx run baz:lint
       - nx run foo:lint

Expected Behavior

 NX   Ran target lint for 3 projects (3s)                                                                                                                                                                          
                                                                                                                                                                                                                   
   √  0/3 succeeded [0 read from cache]                                                                                                                                                                            
                                                                                                                                                                                                                   
   ×  3/3 targets failed, including the following:                                                                                                                                                                 

      - nx run foo:lint
      - nx run baz:lint
      - nx run bar:lint

Related Issue(s)

Fixes #23115

@Den-dp Den-dp requested a review from a team as a code owner May 1, 2024 13:36
@Den-dp Den-dp requested a review from FrozenPandaz May 1, 2024 13:36
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 1:38pm

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 307f8d4 into nrwl:master May 1, 2024
6 checks passed
@Den-dp Den-dp deleted the fix/nice-padding-for-failed-tasks branch May 1, 2024 16:21
Copy link

github-actions bot commented May 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missaligned padding for terminal output with failed tasks
2 participants