-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack): change plugin import paths to speed up config loading #23021
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ce1ab8b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
d69cea9
to
37d7393
Compare
// TODO(v20): Remove this in favor of deep imports in order to load configs faster (150-200ms faster). | ||
/** @deprecated Use NxAppWebpackPlugin from `@nx/webpack/app-plugin` instead. */ | ||
export const NxWebpackPlugin = NxAppWebpackPlugin; | ||
/** @deprecated Use NxTsconfigPathsWebpackPlugin from `@nx/webpack/tsconfig-paths-plugin` instead. */ | ||
export const NxTsconfigPathsWebpackPlugin = _NxTsconfigPathsWebpackPlugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a migration in a followup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, planning to next week.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR updates the import for
NxWebpackPlugin
andNxReactWebpackPlugin
to avoid importing too many things. This change reduces config loading by about 33%.The imports are now as follows:
The old paths from
@nx/webpack
and@nx/react
continues to work, but are deprecated. Will do a follow-up before Nx 20 to update existing configs.Expected Behavior
Related Issue(s)
Fixes #