-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): fix publish script #22981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
fix_publish
branch
5 times, most recently
from
April 24, 2024 18:29
e329c2e
to
f29c76b
Compare
jaysoo
requested review from
a team,
leosvelperez,
Coly010,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
April 24, 2024 21:46
jaysoo
changed the title
fix(repo): update publish script so we install deps in docker containers
fix(misc): fix publish script
Apr 24, 2024
FrozenPandaz
approved these changes
Apr 24, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit 8cd326e)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have crystalized the repo, we need to ensure that native packages are installed based on the architecture of the machine. For example,
@nx/nx-linux-x64-musl
must be installed when publishing here.