fix(core): fix cursor being hidden and process shutdown for ctrl c #22895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f1a6b82. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Apr 19, 2024
FrozenPandaz
force-pushed
the
fix-ctrl-c
branch
from
abef1e4 to
efa7a53
Compare
FrozenPandaz
force-pushed
the
fix-ctrl-c
branch
from
efa7a53 to
f1a6b82
Compare
4 tasks
AgentEnder
pushed a commit
to AgentEnder/nx
that referenced
this pull request
Apr 23, 2024
FelixMalfait
pushed a commit
to twentyhq/twenty
that referenced
this pull request
Apr 24, 2024
Fixes: #5125 Updated nx version that includes fix (see fix PR: nrwl/nx#22895, release confirming fix: https://github.com/nrwl/nx/releases/tag/18.3.3) <img width="291" alt="image" src="https://github.com/twentyhq/twenty/assets/68029599/b72b4a5c-9957-445d-b8b2-8352122cade8">
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When Nx starts, the dynamic terminal lifecycle hides the cursor. When the process is interrupted, the cursor is not re-shown.
Expected Behavior
When the process is interrupted, the cursor is re-shown.
Related Issue(s)
Fixes #22895