fix(core): fix init logging and package.json updates #22843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9cb0b9c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
reviewed
Apr 16, 2024
| '- Enabled computation caching!', | ||
| `- Run "${pmc.exec} nx run-many --t build" to run the build target for every project in the workspace. Run it again to replay the cached computation.`, | ||
| ` - https://nx.dev/features/cache-task-results`, | ||
| `- Run "${pmc.exec} nx graph" to see the graph of the monorepo. It will show tasks that you can run with Nx.`, |
There was a problem hiding this comment.
graph of the monorepo - it may be a standalone workspace
Maybe reword to `Run "${pmc.exec} nx graph" to explore the projects and tasks in your workspace.
FrozenPandaz
force-pushed
the
fix-init
branch
2 times, most recently
from
13afdd7 to
26a67d1
Compare
jaysoo
approved these changes
Apr 16, 2024
FrozenPandaz
force-pushed
the
fix-init
branch
2 times, most recently
from
3db1865 to
3be666a
Compare
AgentEnder
approved these changes
Apr 16, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The "final" message for the init flow is not always at the bottom of the logs. For the new init flow, it gets covered up by all the init logs. Also, for npm monorepos, all
package.jsonfiles havenx: {}added which should not be the case for anypackage.jsonfiles in the case of a monorepo.Expected Behavior
The final message for the init flow appears at the bottom of the logs. All the
package.jsonfiles are also not touched for a npm workspace case.Related Issue(s)
Fixes #