Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): add target groups and technology icon #22839

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Apr 16, 2024

Current Behavior

Expected Behavior

Screenshot 2024-04-23 at 1 42 14 PM Screenshot 2024-04-23 at 1 42 08 PM Screenshot 2024-04-23 at 1 42 02 PM

Related Issue(s)

Fixes #

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 26, 2024 4:05pm

@xiongemi xiongemi changed the title feat(graph): add target groups feat(graph): add target groups and technology icon Apr 16, 2024
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from b2595a6 to 64fa110 Compare April 16, 2024 14:44
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 64fa110 to 465113f Compare April 16, 2024 14:54
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 465113f to cc0d56c Compare April 16, 2024 15:56
@FrozenPandaz FrozenPandaz marked this pull request as draft April 16, 2024 20:56
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from cc0d56c to 7cae666 Compare April 19, 2024 05:29
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 7cae666 to 69f9caf Compare April 22, 2024 06:21
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 69f9caf to 5b6bcb9 Compare April 22, 2024 06:36
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 5b6bcb9 to 9958ca5 Compare April 22, 2024 14:49
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 9958ca5 to e4a3566 Compare April 22, 2024 15:35
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from e4a3566 to ed00c91 Compare April 22, 2024 15:45
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from ed00c91 to 846ef65 Compare April 23, 2024 01:38
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 846ef65 to c2574f1 Compare April 23, 2024 17:41
@xiongemi xiongemi marked this pull request as ready for review April 23, 2024 17:42
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from c2574f1 to 85bbdad Compare April 24, 2024 23:23
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxKless Could you take a look at the UI code please?

graph/ui-icons/src/lib/technology-icon.tsx Show resolved Hide resolved
packages/gradle/src/plugin/nodes.ts Outdated Show resolved Hide resolved
packages/gradle/src/plugin/nodes.ts Outdated Show resolved Hide resolved
nx.json Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 85bbdad to f770500 Compare April 25, 2024 16:54
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from f770500 to 27a6cff Compare April 25, 2024 17:41
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 27a6cff to f83eb1a Compare April 25, 2024 18:57
@xiongemi xiongemi requested a review from FrozenPandaz April 25, 2024 19:13
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from f83eb1a to 1b775f6 Compare April 26, 2024 05:51
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 1b775f6 to 746a5e0 Compare April 26, 2024 13:13
@xiongemi xiongemi force-pushed the feature/nxc-487-project-details-view-groups-targets branch from 746a5e0 to 0a09e14 Compare April 26, 2024 15:56
@FrozenPandaz FrozenPandaz merged commit aa82f03 into nrwl:master Apr 29, 2024
6 checks passed
Copy link

github-actions bot commented May 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants