Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): errors thrown when creating projects should prevent running targets #22807

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

Errors are included in the successful results, preventing them from halting execution

Expected Behavior

Errors are properly thrown

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner April 12, 2024 15:18
@AgentEnder AgentEnder requested a review from xiongemi April 12, 2024 15:18
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:32pm

Copy link

nx-cloud bot commented Apr 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5eb3778. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder force-pushed the fix/project-configurations-error branch from 25581eb to 649853c Compare April 12, 2024 21:13
@AgentEnder AgentEnder requested a review from FrozenPandaz April 12, 2024 22:30
@AgentEnder AgentEnder force-pushed the fix/project-configurations-error branch from 649853c to f38e31f Compare April 15, 2024 14:44
@AgentEnder AgentEnder force-pushed the fix/project-configurations-error branch from f38e31f to 5eb3778 Compare April 15, 2024 15:31
@AgentEnder AgentEnder requested a review from FrozenPandaz April 15, 2024 16:06
@FrozenPandaz FrozenPandaz merged commit e97c588 into nrwl:master Apr 15, 2024
6 checks passed
AgentEnder added a commit to AgentEnder/nx that referenced this pull request Apr 23, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants