feat(core): load root .env files on daemon #22786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
force-pushed
the
feat/load-dotenv-on-daemon
branch
from
40f262b to
4e1c0a4
Compare
AgentEnder
force-pushed
the
feat/load-dotenv-on-daemon
branch
from
4e1c0a4 to
b32f131
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b32f131. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
approved these changes
Apr 11, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We use environment variables for experimental feature flags, which sometimes need to be used on the daemon. Its common to list these variables in a .env file, which is loaded when the CLI is initialized.
The daemon is started with an environment that consists of some custom settings, combined with the process.env. This environment is set as a constant at the module level, so the value is captured the first time the daemon client is required in.
This appears to occur before the dotenv config function has been used, so feature flags specified in
.envare not propogated to the daemon correctly.Expected Behavior
Feature flags specified in
.envpropogate to the daemon.Related Issue(s)
Fixes #