Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): respect skipPackageJson correctly across generators #22777

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 11, 2024

Current Behavior

A few @nx/angular generators do not fully respect the --skipPackageJson option.

Expected Behavior

The @nx/angular generators should fully respect the --skipPackageJson option and not make any changes to it when provided.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 11, 2024
@leosvelperez leosvelperez requested review from a team as code owners April 11, 2024 11:45
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 11, 2024 11:51am

@leosvelperez leosvelperez merged commit a216764 into nrwl:master Apr 11, 2024
6 checks passed
@leosvelperez leosvelperez deleted the angular/skip-package-json-fixes branch April 11, 2024 14:15
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants