fix(vite): get tsconfig from new path including target #22775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 88fe30b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ms-tng
force-pushed
the
fix/vite-get-tsconfig-from-new-path
branch
from
07c9adf to
de7d861
Compare
ms-tng
force-pushed
the
fix/vite-get-tsconfig-from-new-path
branch
from
de7d861 to
4213333
Compare
ms-tng
force-pushed
the
fix/vite-get-tsconfig-from-new-path
branch
from
1b92ada to
88fe30b
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
May 9, 2024
## Current Behavior Since v18.2.3 (e4c4697) the `tsconfig.generated.json` file generated if `"buildLibsFromSource": false` is placed under a path containing the current build target. The `nx-tsconfig-paths` plugin of `@nx/vite` was not updated accordingly, so now it doesn't find `tsconfig.generated.json`, effectively causing `@nx/vite` to ignore the `"buildLibsFromSource": false` setting. ## Expected Behavior With this PR, `nx-tsconfig-paths` finds `tsconfig.generated.json` at the correct path, so `"buildLibsFromSource": false` works as it did before v18.2.3. (cherry picked from commit b4f6e42)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Since v18.2.3 (e4c4697) the
tsconfig.generated.jsonfile generated if"buildLibsFromSource": falseis placed under a path containing the current build target. Thenx-tsconfig-pathsplugin of@nx/vitewas not updated accordingly, so now it doesn't findtsconfig.generated.json, effectively causing@nx/viteto ignore the"buildLibsFromSource": falsesetting.Expected Behavior
With this PR,
nx-tsconfig-pathsfindstsconfig.generated.jsonat the correct path, so"buildLibsFromSource": falseworks as it did before v18.2.3.