fix(angular): fix dynamic module federation generation #22724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f40f10a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
angular/fix-mf-dynamic-generation
branch
from
7ff91dc to
f40f10a
Compare
Coly010
approved these changes
Apr 8, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 8, 2024
(cherry picked from commit 18a2878)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx g @nx/angular:host shell --remote=login --dynamicwhen theloginproject already exists:loginremote is not added to the Dynamic MF manifest (assets/module-federation.manifest.json)loginremote is added to the Static MF configuration (module-federation.config.ts)loginremote is not added to theshellroutesExpected Behavior
Running
nx g @nx/angular:host shell --remote=login --dynamicwhen theloginproject already exists:loginremote should be added to the Dynamic MF manifest (assets/module-federation.manifest.json)loginremote should not be added to the Static MF configuration (module-federation.config.ts)loginremote should be added to theshellroutesRelated Issue(s)
Fixes #