-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update pty version to add windows specific flags #22711
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dfaee09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
(cherry picked from commit 32144bb)
hi @AgentEnder
|
the steps that always reproduce the problem
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
In #21683, we swapped the version of
portable_pty
to a forked version containing a bug fix for windows users. Unfortunately, the cargo installation pulled down a revision from GitHub that was 1 commit behind head, and missed part of the fix.We hope that including the full fix will resolve some issues users on windows are facing with a hanging terminal + outputted ansi codes. Unfortunately, we have been unable to reliably reproduce the reported issue before the fix so we haven't been able to confidently validate the fix either.