Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update pty version to add windows specific flags #22711

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Apr 5, 2024

In #21683, we swapped the version of portable_pty to a forked version containing a bug fix for windows users. Unfortunately, the cargo installation pulled down a revision from GitHub that was 1 commit behind head, and missed part of the fix.

We hope that including the full fix will resolve some issues users on windows are facing with a hanging terminal + outputted ansi codes. Unfortunately, we have been unable to reliably reproduce the reported issue before the fix so we haven't been able to confidently validate the fix either.

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 10:51pm

@AgentEnder AgentEnder marked this pull request as ready for review April 8, 2024 17:46
@AgentEnder AgentEnder requested review from a team, FrozenPandaz and vsavkin as code owners April 8, 2024 17:46
@AgentEnder AgentEnder mentioned this pull request Apr 8, 2024
4 tasks
@AgentEnder AgentEnder merged commit 32144bb into nrwl:master Apr 8, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix/update-pty-version branch April 8, 2024 21:25
FrozenPandaz pushed a commit that referenced this pull request Apr 8, 2024
@robertIsaac
Copy link
Contributor

hi @AgentEnder
it might not be related, but I still get ^[[4;1R and the script freeze
image
this is webstorm terminal
same happen in native powershell, but it doesn't output anything and just hangs
here is my nx report

nx report

 NX   Report complete - copy this into the issue template

Node   : 20.11.1
OS     : win32-x64
yarn   : 4.1.1

nx                 : 18.2.4
@nx/js             : 18.2.4
@nx/jest           : 18.2.4
@nx/linter         : 18.2.4
@nx/eslint         : 18.2.4
@nx/workspace      : 18.2.4
@nx/angular        : 18.2.4
@nx/cypress        : 18.2.4
@nx/devkit         : 18.2.4
@nx/eslint-plugin  : 18.2.4
@nx/plugin         : 18.2.4
@nrwl/tao          : 18.2.4
@nx/web            : 18.2.4
@nx/webpack        : 18.2.4
typescript         : 5.4.3
---------------------------------------
Registered Plugins:
@nx/cypress/plugin
@nx/eslint/plugin
---------------------------------------
Community plugins:
@compodoc/compodoc       : 1.1.18
@ngneat/transloco        : 3.1.4
@ngrx/component          : 17.0.1
@ngrx/component-store    : 17.0.1
@ngrx/effects            : 17.0.1
@ngrx/entity             : 17.0.1
@ngrx/router-store       : 17.0.1
@ngrx/schematics         : 17.0.1
@ngrx/store              : 17.0.1
@ngrx/store-devtools     : 17.0.1
@testing-library/angular : 11.0.2
---------------------------------------
Local workspace plugins:
         workspace-plugin

@robertIsaac
Copy link
Contributor

robertIsaac commented Apr 12, 2024

the steps that always reproduce the problem

  1. in terminal one run yarn nx s -c=e2e
  2. in terminal two run yarn nx run web-app-e2e:e2e --spec=path-to-test --skip-nx-cache
  3. after step 2 is finished, in terminal one cancel using ctrl+c then run again yarn nx s -c=e2e

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants