Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): migrate to latest vite-plugin-dts #22614

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 2, 2024

Current Behavior

We are currently installing an outdated version of vite-plugin-dts with @nx/vite:configuration generator.

Expected Behavior

Ensure 3.8.1 is used for vite-plugin-dts.

Related Issue(s)

Fixes #22199

@Coly010 Coly010 requested a review from a team as a code owner April 2, 2024 12:51
@Coly010 Coly010 requested a review from jaysoo April 2, 2024 12:51
@Coly010 Coly010 self-assigned this Apr 2, 2024
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 2:04pm

@Coly010 Coly010 force-pushed the vite-dts-upgrade branch from 9d394b6 to de45e96 Compare April 2, 2024 14:02
@Coly010 Coly010 requested review from a team as code owners April 2, 2024 14:02
@Coly010 Coly010 merged commit 9e13c85 into nrwl:master Apr 2, 2024
6 checks passed
@Coly010 Coly010 deleted the vite-dts-upgrade branch April 2, 2024 15:33
FrozenPandaz pushed a commit that referenced this pull request Apr 2, 2024
Copy link

github-actions bot commented Apr 9, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated vite.config.ts for a @nx/js:lib generated w/ --bundler=vite
2 participants