Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): prevent false positive validation due to option default value in dev-server executor #22606

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #22590

@leosvelperez leosvelperez self-assigned this Apr 2, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner April 2, 2024 08:12
@leosvelperez leosvelperez requested a review from jaysoo April 2, 2024 08:12
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 8:13am

@leosvelperez leosvelperez requested a review from Coly010 April 2, 2024 08:18
@leosvelperez leosvelperez merged commit 2aed31f into nrwl:master Apr 2, 2024
6 checks passed
@leosvelperez leosvelperez deleted the angular/fix-wrong-validation branch April 2, 2024 09:32
FrozenPandaz pushed a commit that referenced this pull request Apr 2, 2024
… value in dev-server executor (#22606)

(cherry picked from commit 2aed31f)
Copy link

github-actions bot commented Apr 9, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular dev-server (NX) builder, not usable with NX 18 and Angular < 16
2 participants