-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): use loadConfigFile from devkit rather than @nuxt/kit #22571
Conversation
b0a2a38
to
3480c2c
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0c0ab15. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
416854a
to
e1ddf5f
Compare
7d088cf
to
43aacc7
Compare
); | ||
} | ||
const buildOutputPath = normalizeOutputPath(nuxtBuildDir, projectRoot); | ||
const buildOutputPath = normalizeOutputPath( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually only want to cache the .nuxt
folder. This is consistent with Next.js where we cache only .next
folder. Previously, this logic was to handle caching dist/<app>
rather than just dist/<app>/.nuxt
, but we've since moved the default buildDir
back to within the project root anyway. We cannot cache the entire {projectRoot}
, which includes source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
43aacc7
to
4f63ee6
Compare
4f63ee6
to
0c0ab15
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
When using
@nuxt/kit
to loadnuxt.config.ts
files, it can result in errors when used in conjunction with@nx/vite/plugin
(and theloadConfigFile
function fromvite
).This PR switches to our own function from
@nx/devkit
, which we can guarantee plays nicely with@nx/cypress
,@nx/playwright
, and anything else that uses the same plugin.Note: When we isolate each crystal plugin into their own worker, this issue should be resolved as well. However, this is a quicker fix with smaller impact.
Current Behavior
Errors can occur during graph construction when combining nuxt + vitest + playwright/cypress.
Expected Behavior
Errors should not occur during graph construction.
Related Issue(s)
Fixes #