fix(webpack): resolve assets from executor options as relative to workspace root #22544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 816cfb2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
commented
Mar 27, 2024
| options // plugin options take precedence | ||
| options, | ||
| // executor options take precedence (especially for overriding with CLI args) | ||
| originalTargetOptions |
There was a problem hiding this comment.
The order here was previously set wrong. The executor options should override plugin options, since users can pass CLI args, or have overrides in configurations.
Coly010
approved these changes
Mar 27, 2024
ndcunningham
approved these changes
Mar 27, 2024
jaysoo
force-pushed
the
webpack_executor_assets
branch
from
2dcacc4 to
816cfb2
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix to relative asset paths introduced a regression when using
@nx/webpack:webpackexecutor.When options are passed from the executor, the paths are relative to the workspace root not project root. Thus, we need special handling when normalizing executor options.
Current Behavior
Executor is resolving assets relative to project root.
Expected Behavior
Executor options should always be relative to workspace root for consistency.
Related Issue(s)
Fixes #