Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): combine executor properties with name env before passing to run commands #22502

Closed

Conversation

StalkAltan
Copy link
Member

Current Behavior

Nx's environment variable loading is also called env, which would overwrite the nx:run-commands executor env property value. Combine the two if an env property from the executor exists.

Expected Behavior

env executor property is propagated properly

… to run commands

Nx's environment variable loading is also called `env`, which would overwrite the nx:run-commands executor `env` property value. Combine the two if an `env` property from the executor exists.
@StalkAltan StalkAltan requested a review from a team as a code owner March 26, 2024 01:05
@StalkAltan StalkAltan requested a review from FrozenPandaz March 26, 2024 01:05
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 1:06am

@FrozenPandaz
Copy link
Collaborator

Duplicate of #22426

@FrozenPandaz FrozenPandaz marked this as a duplicate of #22426 Mar 27, 2024
Copy link

github-actions bot commented Apr 2, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants