Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): align nx init package.json scripts handling when deselecting all plugins #22490

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Running nx init and choosing to add any Nx core plugin results in package.json#nx.includedScripts being set, excluding all scripts.
Running nx init and not selecting any Nx core plugin results in package.json#nx being set (no includedScripts) and nx exec -- prepended to the scripts selected as cacheable.

Expected Behavior

Running nx init should always set package.json#nx.includedScripts defaulting to []. When the user doesn't select any plugin and selects some cacheable operations, these will be added to the includedScripts and no nx exec -- will be prepended to any script.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 25, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner March 25, 2024 14:24
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 2:25pm

@FrozenPandaz FrozenPandaz merged commit bc4339c into nrwl:master Mar 26, 2024
6 checks passed
@leosvelperez leosvelperez deleted the misc/nx-init-inconsistencies branch March 27, 2024 09:15
Copy link

github-actions bot commented Apr 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants