Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nx-dev): Add feedback CTA #22455

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Mar 22, 2024

Adds Feedback CTA to all pages that have the table of contents

The changes include:

  1. Feedback CTA and Edit this page are now listed with the table of contents.
  2. The Feedback CTA will only be shown either in the Table of Contents or before the footer (Not all pages have Table of Contents)
  3. The Feedback opens a Modal dialog which gives the options of opening an issue or providing a suggestion

Can be seen here:
Screenshot 2024-03-28 at 4 08 00 PM

Which opens:
Screenshot 2024-03-28 at 4 08 25 PM

@ndcunningham ndcunningham self-assigned this Mar 22, 2024
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 2, 2024 4:36pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few minor tweaks

nx-dev/feature-doc-viewer/src/lib/doc-viewer.tsx Outdated Show resolved Hide resolved
tsconfig.base.json Outdated Show resolved Hide resolved
@FrozenPandaz FrozenPandaz merged commit b0b424c into master Apr 3, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feat/nx-dev-add-feedback branch April 3, 2024 19:45
Copy link

github-actions bot commented Apr 9, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants