Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix no plugins found for nx init without packge.json #22434

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner March 21, 2024 15:22
@xiongemi xiongemi requested a review from FrozenPandaz March 21, 2024 15:22
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 4:40am

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still the issue with the --help being printed out.

plugins.forEach((plugin) => {
execSync(`./nx add ${plugin}`, {
stdio: 'inherit',
const detectPluginsResponse = await detectPlugins();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make detectPlugins return an empty array?

@xiongemi xiongemi force-pushed the feature/nxc-505-npx-nx-init-installs-the-nx-folder-correctly-in-a-folder branch 3 times, most recently from be634a8 to f63ce21 Compare March 21, 2024 22:00
@xiongemi xiongemi force-pushed the feature/nxc-505-npx-nx-init-installs-the-nx-folder-correctly-in-a-folder branch from f63ce21 to 68f6214 Compare March 22, 2024 04:39
@xiongemi xiongemi requested a review from FrozenPandaz March 22, 2024 05:36
@FrozenPandaz FrozenPandaz merged commit b7b70da into nrwl:master Mar 22, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Mar 25, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants