fix(nx-plugin): tslib is not set as a dependency when using create-package generator #22429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c99f1c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jogelin
force-pushed
the
fix-create-package-tslib-dependency
branch
from
fccff86 to
ef45aca
Compare
jogelin
force-pushed
the
fix-create-package-tslib-dependency
branch
from
ef45aca to
da5be9f
Compare
xiongemi
approved these changes
Jun 27, 2024
FrozenPandaz
approved these changes
Jul 5, 2024
|
Thank you for your contribution! LGTM 🎉 |
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 5, 2024
…ckage generator (#22429) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior The linting failed on clean `create-nx-plugin` generation:  ## Expected Behavior After a clean generation, build, test, and lint should be successful Co-authored-by: Emily Xiong <[email protected]> (cherry picked from commit 23ce6af)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The linting failed on clean
create-nx-plugingeneration:Expected Behavior
After a clean generation, build, test, and lint should be successful