fix(bundling): prevent sensitive keys from being bundled #22413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eb2f58e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
approved these changes
Mar 20, 2024
ndcunningham
approved these changes
Mar 20, 2024
jaysoo
force-pushed
the
fix_sensitive_env_vars
branch
3 times, most recently
from
5fd72ce to
7e3c019
Compare
jaysoo
force-pushed
the
fix_sensitive_env_vars
branch
from
7e3c019 to
eb2f58e
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit b7ffb25)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
NX_CLOUD_ENCRYPTION_KEYandNX_CLOUD_ACCESS_TOKENfrom bundled in application code. This could happen ifprocess.envobject is used, such as:The build process swaps out
process.envwith the object containing allNX_environment variables, including the secrets. This problem was noted by Payfit and Hasura.In Nx 19, we will introduce a breaking change to only bundle in vars prefixed with
NX_PUBLIC.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #