Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): override Path env variable on Windows platform #22382

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

joelpelaez
Copy link
Contributor

closed #22359

Current Behavior

Execute tasks than run commands like vite or webpack-cli on Windows terminates in error

Expected Behavior

Execute tasks successfully

Related Issue(s)

Fixes #22359

@joelpelaez joelpelaez requested a review from a team as a code owner March 19, 2024 01:21
@joelpelaez joelpelaez requested a review from xiongemi March 19, 2024 01:21
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 1:22am

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 384d874 into nrwl:master Mar 19, 2024
6 checks passed
arekkubaczkowski pushed a commit to arekkubaczkowski/nx that referenced this pull request Mar 19, 2024
FrozenPandaz pushed a commit that referenced this pull request Mar 25, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX 18.1.1 cannot run task than use direct commands (like vite or webpack-cli)
2 participants