feat(core): validate that outputs is an array of strings #22371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b19eacb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
FrozenPandaz
requested changes
Mar 21, 2024
Comment on lines
138
to
142
| const invalidOutputsTypeError = | ||
| InvalidOutputsTypeError.maybeGetError(outputs); | ||
| if (invalidOutputsTypeError) { | ||
| throw invalidOutputsTypeError; | ||
| } |
There was a problem hiding this comment.
Can you change this to an assert function please?
Something like assertOutputsAreValidType
MJez29
force-pushed
the
validate-outputs-type
branch
from
e9bb48c to
b19eacb
Compare
FrozenPandaz
approved these changes
Apr 30, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
I accidentally configured my target outputs as
And was confused by the error message
Expected Behavior
A slightly nicer error message
I also made it so that if you enter non-string values in the array it flags them