Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): remove @nrwl/ rescope message from codeblocks #22184

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 6, 2024

Remove the @nrwl/ rescope message from codeblocks since new users do not need to know about this, and existing users have mostly migrated to Nx 16+.

Screenshot 2024-03-06 at 1 52 44 PM

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 6, 2024 7:57pm

@jaysoo jaysoo marked this pull request as ready for review March 6, 2024 19:17
@jaysoo jaysoo requested a review from a team as a code owner March 6, 2024 19:17
@jaysoo jaysoo requested a review from juristr March 6, 2024 19:17
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the terminal-video.component.tsx file so that it doesn't use the isMessageBelow prop.

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you can merge when you update the reference

@jaysoo jaysoo force-pushed the docs_remove_rescope branch from a42beee to cfc6f31 Compare March 6, 2024 19:52
@jaysoo jaysoo merged commit 8030bd7 into master Mar 6, 2024
6 checks passed
@jaysoo jaysoo deleted the docs_remove_rescope branch March 6, 2024 20:18
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants