Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): split e2e tasks for nx-dev-e2e #22181

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 6, 2024

This PR splits the Playwright e2e task for nx-dev-e2e. This uses the @nx/playwright/plugin crystal plugin for the inferred split tasks.

Note: The nx-dev is not using @nx/next/plugin to infer Next.js tasks, since there is an issue with SIGTERM handling that need to be fixed first.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo marked this pull request as ready for review March 6, 2024 16:24
@jaysoo jaysoo requested review from FrozenPandaz, vsavkin and a team as code owners March 6, 2024 16:24
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 6, 2024 6:57pm

@jaysoo jaysoo force-pushed the chore_nx_dev_task_splitting branch 2 times, most recently from d60a1e4 to afe5878 Compare March 6, 2024 16:29
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm the images still load

@FrozenPandaz FrozenPandaz merged commit 45e1d78 into master Mar 19, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the chore_nx_dev_task_splitting branch March 19, 2024 17:40
arekkubaczkowski pushed a commit to arekkubaczkowski/nx that referenced this pull request Mar 19, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants