Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): fix move generator when there is a list export in the same file as path to update #22070

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

mgawrys-recruitee
Copy link
Contributor

@mgawrys-recruitee mgawrys-recruitee commented Feb 29, 2024

closes #22030
It seems like moduleIdentifier is undefined for export lists that are not a reexport. moduleSpecifier is defined for import declaration, but optional for ExportDeclaration
https://github.com/microsoft/TypeScript/blob/2d70b57df4b64a3daef252abb014562e6ccc8f3c/src/compiler/types.ts#L3701

@mgawrys-recruitee mgawrys-recruitee requested a review from a team as a code owner February 29, 2024 10:10
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 24, 2024 7:34am

@mgawrys-recruitee
Copy link
Contributor Author

It was fixed in #21715

@AgentEnder AgentEnder merged commit c002b54 into nrwl:master Jun 4, 2024
5 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move generator errors if in a file with paths to change there's a list export
2 participants