Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): update cypress version #21961

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 23, 2024

Update the version of Cypress to ^13.6.6, which contains a fix for cypress-io/cypress#28982.

Related to: #21917

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 23, 2024
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 11:30am

@leosvelperez leosvelperez marked this pull request as ready for review February 23, 2024 09:09
@leosvelperez leosvelperez requested a review from a team as a code owner February 23, 2024 09:09
@mandarini
Copy link
Member

Do we need a migration?

@leosvelperez leosvelperez enabled auto-merge (squash) February 23, 2024 10:53
@leosvelperez
Copy link
Member Author

leosvelperez commented Feb 23, 2024

Do we need a migration?

I opted not to provide one given folks were advised to pin the version and we also pinned it, but the change was not released and I guess some folks might not have seen that and we could do it for them. I'll add one 👍🏻

@leosvelperez leosvelperez force-pushed the cypress/restore-version branch from 520f00b to 5a56877 Compare February 23, 2024 11:27
@leosvelperez leosvelperez force-pushed the cypress/restore-version branch from 5a56877 to 0135250 Compare February 23, 2024 11:29
@leosvelperez leosvelperez merged commit dd2c7d2 into nrwl:master Feb 23, 2024
6 checks passed
@leosvelperez leosvelperez deleted the cypress/restore-version branch February 23, 2024 13:44
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants