Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): logs from rm-default-collection should render properly #21953

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(misc): logs from rm-default-collection should render properly #21953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/nx/src/migrations/update-17-0-0/rm-default-collection-npm-scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { formatChangedFilesWithPrettierIfAvailable } from '../../generators/inte
import { Tree } from '../../generators/tree';
import { readNxJson, updateNxJson } from '../../generators/utils/nx-json';
import { readJson } from '../../generators/utils/json';
import { logger } from '../../utils/logger';
import { output } from '../../utils/output';
import { NxJsonConfiguration } from '../../config/nx-json';
import { joinPathFragments } from '../../utils/path';

Expand Down Expand Up @@ -54,7 +54,7 @@ function warnNpmScopeHasChanged(
const packageJsonName = readJson(tree, 'package.json').name;

if (newScope) {
logger.warn({
output.warn({
title: 'npmScope has been removed from nx.json',
bodyLines: [
'This will now be read from package.json',
Expand All @@ -69,7 +69,7 @@ function warnNpmScopeHasChanged(
});
} else {
// There is no scope in package.json
logger.warn({
output.warn({
title: 'npmScope has been removed from nx.json',
bodyLines: [
'This will now be read from package.json',
Expand Down