Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): init generator should add @nx/vite to dependencies #21911

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 21, 2024

Current Behavior

The @nx/nuxt:init generator will add @nx/vite/plugin to the plugins: [] in nx.json when Crystal is turned on.
However, if the workspace does not already have @nx/vite installed, the graph will fallover during construction, preventing subsequent nx commands from executing.

Expected Behavior

Ensure that the @nx/nuxt:init generator adds @nx/vite to the workspace.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner February 21, 2024 10:52
@Coly010 Coly010 self-assigned this Feb 21, 2024
@Coly010 Coly010 requested a review from ndcunningham February 21, 2024 10:52
Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 11:54am

@Coly010 Coly010 requested a review from a team as a code owner February 21, 2024 11:27
@Coly010 Coly010 requested a review from AgentEnder February 21, 2024 11:27
@mandarini mandarini merged commit e7826cd into nrwl:master Feb 21, 2024
6 checks passed
@Coly010 Coly010 deleted the fix/nuxt-init branch February 21, 2024 12:25
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants