fix(core): propagate verbose flag when running init generator dur…

[tinesoft]

…ing nx add command

Current Behavior

When using the new nx add <plugin> to install a plugin (as devDependencies) and initializes it (if a init generator exists),
any raw error thrown when calling that generator, is not sent back to user, even if the --verbose flag is provided to the nx add command.

Instead, a generic and not so useful " > NX Failed to initialize @nxrocks/nx-spring-boot. Please check the error above for more details." is displayed...

Here is an example:

$ npx nx add @nxrocks/nx-spring-boot@latest --verbose

✔ Installing @nxrocks/nx-spring-boot@latest...
✖ Initializing @nxrocks/nx-spring-boot...

Command failed: npx nx g @nxrocks/nx-spring-boot:project --keepExistingVersions


 >  NX   Failed to initialize @nxrocks/nx-spring-boot. Please check the error above for more details.

After manually tweaking the @node_modules/nx/src/command-line/add/add.js file, to consider the --verbose flag, I managed to get more helpful insight about the actual underlying error that occurred in my init generator (here, the generator was expecting a required "name" option that was, of course, not provided)

Here is output, when that flag was considered:

AzureAD+TineKondo@LAVA-1T8QJS3 MINGW64 /d/Workspace/git/nx18 (main)
$ npx nx add @nxrocks/nx-spring-boot@latest --verbose

✔ Installing @nxrocks/nx-spring-boot@latest...
⠹ Initializing @nxrocks/nx-spring-boot...
>  NX  Generating @nxrocks/nx-spring-boot:project


 >  NX   Required property 'name' is missing


✖ Initializing @nxrocks/nx-spring-boot...

Command failed: npx nx g @nxrocks/nx-spring-boot:project --keepExistingVersions


 >  NX   Failed to initialize @nxrocks/nx-spring-boot. Please check the error above for more details.

Expected Behavior

Propagate the --verbose flag when running the init generator, so that more information can be output to user if calling that generator failed for some reason.

If not provided at all, or provided with --verbose=false, no extra log is printed (current behavior)

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Feb 19, 2024 2:10pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4fb7857. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --target=e2e --base=31348e2b85ac405bcd21410a0cbdc955af794345 --head=4fb7857974d74359a700ba4c202f6701f49138cb --parallel=1

✅ Successfully ran 5 targets

• nx affected --targets=lint,test,build --base=31348e2b85ac405bcd21410a0cbdc955af794345 --head=4fb7857974d74359a700ba4c202f6701f49138cb --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=31348e2b85ac405bcd21410a0cbdc955af794345 --head=4fb7857974d74359a700ba4c202f6701f49138cb
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=31348e2b85ac405bcd21410a0cbdc955af794345 --head=4fb7857974d74359a700ba4c202f6701f49138cb

---

Sent with 💌 from NxCloud.

[AgentEnder]

Vite failure is unrelated

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.