Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): fixing vue and nuxt welcome templates #21792

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

ZackDeRose
Copy link
Member

Current Behavior

Currently, the vue and nuxt nx-welcome pages have an unfortunate template error resulting in this:
Screenshot 2024-02-12 at 9 28 43 PM

Expected Behavior

no template error

Related Issue(s)

Fixes #

@ZackDeRose ZackDeRose self-assigned this Feb 13, 2024
@ZackDeRose ZackDeRose requested a review from a team as a code owner February 13, 2024 02:29
@ZackDeRose ZackDeRose requested a review from jaysoo February 13, 2024 02:29
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 16, 2024 3:54pm

Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should also be nx connect not nx connect-to-cloud

@ZackDeRose ZackDeRose merged commit fdcd4d0 into nrwl:master Feb 16, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants