Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add tailwind as style prompt option for app gen #21784

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 12, 2024

Current Behavior

We do not prompt the user to use Tailwind as an option when generating a react app either via nx generate or via create-nx-workspace.

Expected Behavior

Prompt the user with an option for Tailwind in both scenarios listed above.

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Feb 12, 2024
@Coly010 Coly010 requested a review from JamesHenry as a code owner February 12, 2024 17:18
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 14, 2024 5:03pm

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an e2e test to make sure build includes the right class names in css?

@Coly010 Coly010 force-pushed the add-tw-to-react-styles branch from adad23c to 44293d4 Compare February 14, 2024 16:57
@Coly010 Coly010 enabled auto-merge (squash) February 14, 2024 16:58
@Coly010 Coly010 merged commit 3b384c7 into nrwl:master Feb 14, 2024
6 checks passed
@Coly010 Coly010 deleted the add-tw-to-react-styles branch February 15, 2024 09:29
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants