Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): full support custom secure host for module federation #21777

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(react): full support custom secure host for module federation #21777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions ...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ async function startDevRemotes(
staticRemotes: string[];
devRemotes: string[];
},
context: ExecutorContext
context: ExecutorContext,
options: ModuleFederationDevServerOptions
) {
const devRemoteIters: AsyncIterable<{ success: boolean }>[] = [];

Expand All @@ -119,6 +120,10 @@ async function startDevRemotes(
},
{
watch: true,
...(options.host ? { host: options.host } : {}),
...(options.ssl ? { ssl: options.ssl } : {}),
...(options.sslCert ? { sslCert: options.sslCert } : {}),
...(options.sslKey ? { sslKey: options.sslKey } : {}),
...(isUsingModuleFederationDevServerExecutor
? { isInitialHost: false }
: {}),
Expand Down Expand Up @@ -291,7 +296,7 @@ export default async function* moduleFederationDevServer(
);
await buildStaticRemotes(staticRemotesConfig, nxBin, context, options);

const devRemoteIters = await startDevRemotes(remotes, context);
const devRemoteIters = await startDevRemotes(remotes, context, options);

const staticRemotesIter =
remotes.staticRemotes.length > 0
Expand All @@ -313,6 +318,10 @@ export default async function* moduleFederationDevServer(
return;
}
try {
const host = options.host ?? 'localhost';
const baseUrl = `http${options.ssl ? 's' : ''}://${host}:${
options.port
}`;
const portsToWaitFor = staticRemotesIter
? [options.staticRemotesPort, ...remotes.remotePorts]
: [...remotes.remotePorts];
Expand All @@ -321,15 +330,13 @@ export default async function* moduleFederationDevServer(
waitForPortOpen(port, {
retries: 480,
retryDelay: 2500,
host: 'localhost',
host: host,
})
)
);

logger.info(
`NX All remotes started, server ready at http://localhost:${options.port}`
);
next({ success: true, baseUrl: `http://localhost:${options.port}` });
logger.info(`NX All remotes started, server ready at ${baseUrl}`);
next({ success: true, baseUrl: baseUrl });
} catch {
throw new Error(
`Timed out waiting for remote to start. Check above for any errors.`
Expand Down