feat(core): execute plugins in isolated processes #21760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
meeroslav,
a team and
leosvelperez
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c3698bf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
34c2ad6 to
90b8753
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
90b8753 to
349e63e
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
349e63e to
2e3ffb0
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
2e3ffb0 to
4342107
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
4342107 to
3c25fce
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
3c25fce to
d1a640b
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
d1a640b to
98d71a2
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
98d71a2 to
57cc74c
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
57cc74c to
4217c99
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
4217c99 to
1eb98d0
Compare
Cammisuli
requested changes
Feb 21, 2024
packages/nx/src/devkit-internals.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| import { shutdownPluginWorkers } from './project-graph/plugins/plugin-pool'; | |||
| const pidMap = new Map<number, string>(); | ||
|
|
||
| export function loadRemoteNxPlugin(plugin: PluginConfiguration, root: string) { | ||
| const isTest = path.extname(__filename) === '.ts'; |
There was a problem hiding this comment.
I understand why we need to do this, but maybe we can change this to be more descriptive.
Comment on lines
210
to
216
| if (process.env.NX_VERBOSE_LOGGING) { | ||
| console.log( | ||
| 'Unable to find local plugin', | ||
| possiblePaths, | ||
| projectRootMappings | ||
| ); | ||
| } |
There was a problem hiding this comment.
Use the new logger.verbose function
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
1eb98d0 to
e6e872b
Compare
Cammisuli
approved these changes
Feb 21, 2024
leosvelperez
approved these changes
Feb 22, 2024
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
e6e872b to
81acbc5
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
2 times, most recently
from
358efad to
44284fa
Compare
AgentEnder
force-pushed
the
feat/isolated-plugins
branch
from
44284fa to
c3698bf
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Project graph plugins are all loaded in the main nx process (or daemon if enabled), which can cause issues when they do things that mutate the global process (E.g. registering a typescript transpiler)
Expected Behavior
Plugins operate in a sandbox
Related Issue(s)
See: https://www.loom.com/share/87febc4db210444aa7f4163a76d7f758