Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): ensure cypress closes the web dev server #21759

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix(testing): ensure cypress closes the web dev server #21759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/cypress/plugins/cypress-preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { lstatSync } from 'fs';
import vitePreprocessor from '../src/plugins/preprocessor-vite';
import { NX_PLUGIN_OPTIONS } from '../src/utils/constants';

import { exec } from 'child_process';
import { spawn } from 'child_process';
import { request as httpRequest } from 'http';
import { request as httpsRequest } from 'https';

Expand Down Expand Up @@ -65,14 +65,19 @@ export function nxBaseCypressPreset(
}

function startWebServer(webServerCommand: string) {
const serverProcess = exec(webServerCommand, {
const serverProcess = spawn(webServerCommand, {
cwd: workspaceRoot,
shell: true,
// Detaching the process on unix will create a process group, allowing us to kill it later
// Windows is fine so we leave it attached to this process
detached: process.platform !== 'win32',
stdio: 'inherit',
});
serverProcess.stdout.pipe(process.stdout);
serverProcess.stderr.pipe(process.stderr);

return () => {
serverProcess.kill();
// child.kill() does not work on linux
// process.kill will kill the whole process group on unix
process.kill(-serverProcess.pid, 'SIGKILL');
};
}

Expand Down