fix(js): babel preset should also check for JEST_WORKER_ID to transpile to CJS #21754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6324edb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
approved these changes
Feb 9, 2024
jaysoo
force-pushed
the
fix_babel_jest
branch
4 times, most recently
from
9fb588c to
c716d66
Compare
jaysoo
force-pushed
the
fix_babel_jest
branch
from
c716d66 to
6324edb
Compare
FrozenPandaz
approved these changes
Feb 9, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a longstanding issue with
@nx/js/babelwhereNODE_ENVbeing anything other thantestwill cause errors due to modules being transpiled as ESM (and Jest not able to run it).Previously, our
@nx/jest:jestexecutor guarantees thisNODE_ENVistest, but now with Project Crystal we are skipping the executor. To know whether we're in Jest context, we should check theJEST_WORKER_IDwhich is always set when using Jest runner.For example, if you generate an app and run Jest with
NODE_ENVset to anything else you'll see an error.Current Behavior
Setting
NODE_ENVto anything other thantestwill result in test failure.Expected Behavior
Our test setup should be resilient against
NODE_ENVnot beingtest.Related Issue(s)
Fixes #