Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): nx release-version resolve-version-spec should normalize fetchSpec #21710

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 8, 2024

Current Behavior

We use npm-package-arg to resolve the fetchSpec for packages. It will return OS-specific paths.
When we try to compare that to the local workspace packages' targetPackage.location, it fails to match, as one path is win-style and the other is unix-style.
This causes issue on Windows for updating the versions of local packages.

Expected Behavior

Normalize the fetchSpec if it is a path, and if it is a win-style path.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner February 8, 2024 12:38
@Coly010 Coly010 requested a review from JamesHenry February 8, 2024 12:38
@Coly010 Coly010 self-assigned this Feb 8, 2024
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 10, 2024 1:22pm

@Coly010 Coly010 force-pushed the fix/nx-release-file-versions branch from 891ccf5 to 03ac573 Compare February 8, 2024 12:48
@Coly010 Coly010 force-pushed the fix/nx-release-file-versions branch from c4300b8 to bdeb153 Compare February 9, 2024 13:39
@JamesHenry JamesHenry merged commit 11e139c into nrwl:master Feb 10, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants