Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(webpack): Add docs for webpack ci deployment #21650

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Feb 6, 2024

Changes

Now the Project Crystal is enabled by default we need to revise our webpack documentation.

Preview

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 7, 2024 5:10pm

@ndcunningham ndcunningham force-pushed the docs/ci-deployment-webpack branch from 1ac7b15 to d003a01 Compare February 6, 2024 20:17
@ndcunningham ndcunningham marked this pull request as ready for review February 6, 2024 20:17
@ndcunningham ndcunningham requested a review from a team as a code owner February 6, 2024 20:17
@ndcunningham ndcunningham force-pushed the docs/ci-deployment-webpack branch 2 times, most recently from 16b0b9b to d182f42 Compare February 6, 2024 20:21
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes.

Why do you say "we are working on a plugin for Vite"? @nx/vite already exists. Does it not have parity with @nx/webpack yet? What does it not do?

docs/shared/recipes/ci-deployment.md Outdated Show resolved Hide resolved
docs/shared/recipes/ci-deployment.md Outdated Show resolved Hide resolved
@ndcunningham
Copy link
Contributor Author

Small changes.

Why do you say "we are working on a plugin for Vite"? @nx/vite already exists. Does it not have parity with @nx/webpack yet? What does it not do?

I think the plugin being referred to here is NxWebpackPlugin so it probably would be called NxVitePlugin which would contain some of the already existing functionality nxViteTsPaths() and also functionality that does not exists for vite generate package.json.

cc: @jaysoo

docs/shared/recipes/ci-deployment.md Outdated Show resolved Hide resolved
@isaacplmann
Copy link
Collaborator

I think the plugin being referred to here is NxWebpackPlugin so it probably would be called NxVitePlugin which would contain some of the already existing functionality nxViteTsPaths() and also functionality that does not exists for vite generate package.json.

cc: @jaysoo

I updated the text to make this more explicit and approved the PR.

@ndcunningham ndcunningham merged commit a6ceef6 into master Feb 7, 2024
6 checks passed
@ndcunningham ndcunningham deleted the docs/ci-deployment-webpack branch February 7, 2024 23:06
FrozenPandaz pushed a commit that referenced this pull request Feb 7, 2024
Co-authored-by: Isaac Mann <[email protected]>
(cherry picked from commit a6ceef6)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants