fix(core): remove logic to reload process with esm loader for Node 18 #21623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 36b212c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
approved these changes
Feb 5, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems problematic to reload the process when we may not need to. The reload is only really needed for workspaces/projects with
type: 'moduleinpackage.jsonfile.By reverting this, we may break new Nx projects using ESM +
.tsconfig files that are not on Node 20. The workaround for those projects is to use Node 20, or manually run Node with--loader ts-node/esmthemselves. If it becomes a wide-spread issue we can look at a better solution then.Current Behavior
Node 18 restarts with
--loader ts-node/esmthat may lead to problems in some environments.Expected Behavior
Don't restart with
--loader ts-node/esmfor Node 18.Related Issue(s)
Fixes #