Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): move next/constants from top-level import to when it is needed #21612

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 5, 2024

If you create a new Nx workspace without @nx/next plugin, then run nx add @nx/next it will error out due to a missing next/constants import. This is because next has not been installed via the init generator yet.

Current Behavior

nx add @nx/next should breaks.

Expected Behavior

nx add @nx/next should work.

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner February 5, 2024 15:57
@jaysoo jaysoo requested a review from mandarini February 5, 2024 15:57
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 3:58pm

@jaysoo jaysoo merged commit 44d33c2 into nrwl:master Feb 5, 2024
6 checks passed
@jaysoo jaysoo deleted the fix_next_plugin branch February 5, 2024 16:40
FrozenPandaz pushed a commit that referenced this pull request Feb 5, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants