Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): package type is module should emit esm #21473

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Feb 1, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #20009

@xiongemi xiongemi requested a review from a team as a code owner February 1, 2024 01:36
@xiongemi xiongemi requested a review from mandarini February 1, 2024 01:36
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 3:54pm

@xiongemi xiongemi force-pushed the bugfix/fix-package-type-module-esm branch from 0581889 to 0665200 Compare February 2, 2024 15:53
@xiongemi xiongemi merged commit d1bf692 into nrwl:master Feb 2, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
FrozenPandaz pushed a commit that referenced this pull request Feb 3, 2024
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/rollup built library errors when using new .cjs.mjs file
2 participants