Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not create new targets from target defaults when packag… #21365

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

…e.json script is not included

Current Behavior

Targets from Target defaults are added when the script is not included in the includedScripts array

Expected Behavior

Targets from Target defaults are not added when the script is not included in the includedScripts array

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner January 26, 2024 20:26
Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 8:26pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) January 26, 2024 20:50
@FrozenPandaz FrozenPandaz merged commit e1bb8bc into nrwl:master Jan 26, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-defaults branch January 29, 2024 16:11
Copy link

github-actions bot commented Feb 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants