fix(release): only add nx-release-publish to public packages #21338
Conversation
JamesHenry
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder and
jaysoo
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c2fb4ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
| 'There are a few possible reasons for this: (1) The projects may be private (2) You may not have an appropriate plugin (such as `@nx/js`) installed which adds the target automatically to public projects (3) You intended to configure the target manually, or exclude those projects via config in nx.json', | ||
| ], | ||
| }); | ||
| process.exit(1); |
There was a problem hiding this comment.
Could this have been thrown as an error? It's quite a lengthy message but since we have a programmatic API, it's weird for their process to suddenly exit after calling the function without a chance to catch it?
There was a problem hiding this comment.
Yes fair point, it would block programmatic consumers. We don’t have handleErrors in use in this command so I’ll double check the experience tomorrow
There was a problem hiding this comment.
So the way I have decided to handle this is leverage the handleErrors function for the CLI usage like we do for the other subcommands, but additionally have an appreciation for whether or not the code is being run via the CLI.
This allows us to keep the CLI error messaging focused on the publish run (where there are no other config errors), instead of having the runCommand failure and then another error message afterwards just reiterating that publishing has failed.
E.g. what I have gone for
vs
no appreciation for how it's being run via the CLI
| @@ -116,36 +115,6 @@ const LARGE_BUFFER = 1024 * 1000000; | |||
| if (options.dryRun) { | |||
| console.warn('Not Publishing because --dryRun was passed'); | |||
| } else { | |||
| // If publishing locally, force all projects to not be private first | |||
There was a problem hiding this comment.
This is removed because @nx/js: handles this?
There was a problem hiding this comment.
No it’s because we agreed that the only workaround for this now was to manually set the targets instead, so I went to do that and realised we don’t have any private projects. If you want me to restore it in case we ever do something like that again in the future I can
There was a problem hiding this comment.
I have restored the behaviour in case we ever need it again in future, and updated the log message to more explicitly cover the fact that a target will now need to be added manually for the private packages
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
nx-release-publishtarget when"private": trueis not set in the package.json of a JS projectnx-release-publishtarget to thepublishcommandversioncommand