Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): required property in schema should be project #21258

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 22, 2024

Current Behavior

The schema for the remix/storybook-configuration generator states that the required property is name, however name is only an alias for project.

Expected Behavior

project should be marked as the required property.

Related Issue(s)

Fixes #20948

@Coly010 Coly010 requested review from a team as code owners January 22, 2024 10:49
@Coly010 Coly010 self-assigned this Jan 22, 2024
Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 22, 2024 10:55am

@jaysoo jaysoo merged commit 9fea60b into nrwl:master Jan 22, 2024
6 checks passed
@Coly010 Coly010 deleted the remix/fix-storybook-configuration-generator branch January 22, 2024 15:25
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/remix:storybook-configuration - Required property 'name' is missing
3 participants