Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): refresh pdv periodically in watch mode #21218

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jan 18, 2024

Just like in the graph mode, we check whether the project graph every 5 seconds to see if anything has changed.
We compare hashes between the old and new project graph and if anything has changed, we update the PDV while keeping the expanded views & scroll position.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:54pm

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing!

  1. Can we have watch: true be the default when we run nx show project test --web
  2. Can we make the interval faster for the project details page? But keep it a bit longer for the graph?

@MaxKless MaxKless requested a review from a team as a code owner January 18, 2024 21:53
@FrozenPandaz FrozenPandaz merged commit b5ffb85 into master Jan 18, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the graph-refresh branch January 18, 2024 22:59
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants