-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graph): refresh pdv periodically in watch mode #21218
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e7d7049. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
f67df00
to
ef5416d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing!
- Can we have
watch: true
be the default when we runnx show project test --web
- Can we make the interval faster for the project details page? But keep it a bit longer for the graph?
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Just like in the graph mode, we check whether the project graph every 5 seconds to see if anything has changed.
We compare hashes between the old and new project graph and if anything has changed, we update the PDV while keeping the expanded views & scroll position.