Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): take vscode light/dark theme into account #21208

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jan 18, 2024

getting the system theme is changed. First we'll check for vscode-dark or vscode-light classes on the body (those are set by vscode automatically). If either exists, we'll use that as the 'system' theme.
If it doesn't, we'll defer to the prefers-color-scheme: dark media query.

We also listen to changes on the document body.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 1:59pm

@MaxKless MaxKless force-pushed the graph-use-vscode-themes branch from b330b94 to 10fa231 Compare January 18, 2024 13:58
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy Migration observer

@FrozenPandaz FrozenPandaz merged commit e4e7f54 into master Jan 18, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the graph-use-vscode-themes branch January 18, 2024 17:04
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants