feat(graph): decouple graph client from nx.dev <Fence> component #21186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
FrozenPandaz,
a team,
vsavkin,
philipjfulcher,
bcabanes and
MaxKless
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 272b46f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
pdv_source_annotations
branch
4 times, most recently
from
c26c920 to
1ed3cc7
Compare
isaacplmann
approved these changes
Jan 17, 2024
jaysoo
force-pushed
the
pdv_source_annotations
branch
from
1ed3cc7 to
985984a
Compare
MaxKless
approved these changes
Jan 17, 2024
meeroslav
approved these changes
Jan 17, 2024
jaysoo
force-pushed
the
pdv_source_annotations
branch
from
985984a to
a0198d5
Compare
jaysoo
force-pushed
the
pdv_source_annotations
branch
from
a0198d5 to
272b46f
Compare
FrozenPandaz
approved these changes
Jan 18, 2024
isaacplmann
pushed a commit
that referenced
this pull request
Jan 18, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new component for rendering JSON blocks inside graph client.
Changes
@nx/shared-ui-fenceto@nx/nx-dev/ui-fence@nx/shared-ui-selectorand inlineSelectorcomponent in@nx/nx-dev/ui-fencelib since it's only used there as an internal component@nx/graph/ui-code-blocklib to render JSON blocks for the project detail viewpreact/debugto graph client so we can use devtools