feat(misc): add layout for project details view #21172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
a team,
vsavkin,
Coly010,
philipjfulcher,
bcabanes and
MaxKless
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bb849c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
pdv-layout
branch
4 times, most recently
from
af594b4 to
876f290
Compare
FrozenPandaz
force-pushed
the
pdv-layout
branch
from
876f290 to
b1f3f36
Compare
MaxKless
approved these changes
Jan 17, 2024
meeroslav
approved these changes
Jan 17, 2024
JamesHenry
approved these changes
Jan 17, 2024
jaysoo
approved these changes
Jan 17, 2024
jaysoo
reviewed
Jan 17, 2024
tsconfig.base.json
Outdated
| @@ -107,6 +107,7 @@ | |||
| "@nx/storybook": ["packages/storybook"], | |||
| "@nx/storybook/*": ["packages/storybook/*"], | |||
| "@nx/typedoc-theme": ["typedoc-theme/src/index.ts"], | |||
| "@nx/ui-theme": ["graph/ui-theme/src/index.ts"], | |||
There was a problem hiding this comment.
Should be @nx/graph/ui-theme to match the other libs and differentiate from @nx/nx-dev.
FrozenPandaz
force-pushed
the
pdv-layout
branch
from
a130e13 to
bb849c9
Compare
isaacplmann
pushed a commit
that referenced
this pull request
Jan 18, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is little page layout for the project details view.
Expected Behavior
There is page layout for the project details view
Related Issue(s)
Fixes #